Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dataStore to SharingDialog types #1664

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

d-rita
Copy link
Contributor

@d-rita d-rita commented Feb 13, 2025

Implements DHIS2-19007


Description

This PR adds the dataStore resource to the list of accepted types for the Sharing Dialog component. This is to support the sharing feature in the new DataStore app.


Checklist

  • API docs are generated
  • Tests were added
  • Storybook demos were added

All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.


@d-rita d-rita requested a review from a team as a code owner February 13, 2025 09:44
@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-1664--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify February 13, 2025 09:49 Inactive
Copy link
Member

@amcgee amcgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@d-rita d-rita merged commit 853f7e4 into master Feb 24, 2025
24 checks passed
@d-rita d-rita deleted the DHIS2-19007/update-sharing-dialog-types branch February 24, 2025 17:32
dhis2-bot added a commit that referenced this pull request Feb 24, 2025
# [10.2.0](v10.1.13...v10.2.0) (2025-02-24)

### Features

* add dataStore to SharingDialog types ([#1664](#1664)) ([853f7e4](853f7e4))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 10.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants